Skip to content

fix: reduce cast calls in service browser #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 2 commits into from
Apr 26, 2023
Merged

fix: reduce cast calls in service browser #1164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aebaa57
fix: reduce cast calls in service browser
bdraco Apr 26, 2023
1f72758
Merge branch 'master' into browser_casts
bdraco Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/zeroconf/_services/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,18 +157,16 @@ def generate_service_query(
question = DNSQuestion(type_, _TYPE_PTR, _CLASS_IN)
question.unicast = qu_question
known_answers = {
cast(DNSPointer, record)
record
for record in zc.cache.get_all_by_details(type_, _TYPE_PTR, _CLASS_IN)
if not record.is_stale(now)
}
if not qu_question and zc.question_history.suppresses(
question, now, cast(Set[DNSRecord], known_answers)
):
if not qu_question and zc.question_history.suppresses(question, now, known_answers):
log.debug("Asking %s was suppressed by the question history", question)
continue
questions_with_known_answers[question] = known_answers
questions_with_known_answers[question] = cast(Set[DNSPointer], known_answers)
if not qu_question:
zc.question_history.add_question_at_time(question, now, cast(Set[DNSRecord], known_answers))
zc.question_history.add_question_at_time(question, now, known_answers)

return _group_ptr_queries_with_known_answers(now, multicast, questions_with_known_answers)

Expand Down