feat: reduce denial of service protection overhead#1157
Merged
Conversation
If there is a device with a bad mdns stack that is flooding the network with response packets there is little we can do but optimize how we handle this as mdns works on a trust model of generally accepting network traffic. Its unlikely that the user is going to remove the offending the device so we will reduce the overhead to deal with one of these.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 99.81% 99.81% -0.01%
==========================================
Files 22 22
Lines 2654 2652 -2
Branches 463 463
==========================================
- Hits 2649 2647 -2
Misses 3 3
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Member
Author
|
This helps a lot with those sonoff plugs that use mdns to send state updates.... 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a device with a bad mdns stack that is flooding the network with response packets there is little we can do but optimize how we handle this as mdns works on a trust model of generally accepting network traffic. Its unlikely that the user is going to remove the offending the device so we will reduce the overhead to deal with one of these.