Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (41ea06a) 99.77% compared to head (fc5a986) 99.77%.

@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          22       22           
  Lines        2646     2654    +8     
  Branches      461      463    +2     
=======================================
+ Hits         2640     2648    +8     
  Misses          4        4           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This should fix all the races with ip address ordering

I think we are missing coverage for a few of these races.

We also didn't handle server name changing before correctly

Going to need to split this into two PRs

One to fix the races with the server name changing

• needs test for that
• needs test for ipv6 address seen last is first
• needs test for invalid dnsaddress in cache

One to avoid the awake on every packet

There is another bug here

self.server needs to start out set to None as well as server_key.

Otherwise we could have addresses in the cache for the ptr name but it actually uses a different name in the dev record and a different address so we end up returning the addresses for the ptr name instead of the srv

Everything that returns self.server might need to be adjusted as well

Still need a test for the server changing via a DNSService update

Need to start off with the original name and than change it