fix: make parsed_scoped_addresses return addresses in the same order as all other methods #1150
Merged
Conversation
There were multiple conversions that can be avoided when processing IP Addresses
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1150 +/- ##
==========================================
- Coverage 99.77% 99.69% -0.08%
==========================================
Files 22 22
Lines 2614 2607 -7
Branches 458 457 -1
==========================================
- Hits 2608 2599 -9
- Misses 4 6 +2
Partials 2 2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parsed_scoped_addresseswould not return addresses in the same order as the other address functions. This lead to unexpected results with thehostvalue.This also improves performance of ip address handling in ServiceInfo as there were multiple conversions that can be avoided when processing IP Addresses