Skip to content

feat: cythonize handlers#1136

Closed
bdraco wants to merge 4 commits into
masterfrom
cython_handlers
Closed

feat: cythonize handlers#1136
bdraco wants to merge 4 commits into
masterfrom
cython_handlers

Conversation

@bdraco

@bdraco bdraco commented Apr 1, 2023

Copy link
Copy Markdown
Member

There are still cases were we cannot answer questions fast enough to keep up with systems (mainly HomeKit) that require a response within a time period to prevent a device from going offline.

We need to optimize the sending responses a bit as well via #1135

Screenshot 2023-03-31 at 1 44 04 PM

@codecov-commenter

codecov-commenter commented Apr 1, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (808c3b2) 99.80% compared to head (fd6313f) 99.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          22       22           
  Lines        2594     2598    +4     
  Branches      456      456           
=======================================
+ Hits         2589     2593    +4     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco

bdraco commented Apr 1, 2023

Copy link
Copy Markdown
Member Author

probably need to figure out whats going wrong with the tests in #1138 first

@bdraco bdraco closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants