feat: optimize the dns cache#1119
Merged
Merged
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1119 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 22 22
Lines 2567 2569 +2
Branches 454 452 -2
=======================================
+ Hits 2560 2562 +2
Misses 5 5
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdraco
commented
Dec 21, 2022
| @@ -487,7 +483,7 @@ def __eq__(self, other: Any) -> bool: | |||
| isinstance(other, DNSNsec) | |||
| and self.next_name == other.next_name | |||
Member
Author
There was a problem hiding this comment.
We can move all the checks after the isinstance into a cdef with the other typed to the same type which will avoid all the python accessor overhead since we can access the struct values in C instead
Member
Author
|
Worked great overnight. #1119 (comment) can happen in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a pxd file for
_cache.pyand cleans up the one for_dns.pyThis also fixes some conflating of
DNSRecordandDNSEntry