test: drop ZeroconfServiceTypes.find() timeouts from 500ms to 200ms on loopback

bdraco · bdraco · commit fcef4dc3c276 · 2026-05-17T17:46:21.000-07:00
`ZeroconfServiceTypes.find()` is just `time.sleep(timeout)` (it doesn't short-circuit on the first matching response), so the timeout becomes a lower bound on the test runtime. Each of these tests calls `find()` twice, paying 1s of pure sleep on top of ~200ms of setup. On loopback the registrar's response lands within a few ms, so 200ms is ~50× headroom. `test_async_zeroconf_service_types` also slept 200ms after `async_register_service` to let the last announce broadcast land — that one already has the `quick_timing` fixture (which patches _REGISTER_TIME=10ms), so 50ms is plenty. Speedups: - test_integration_with_listener: 1.28s → 0.67s - test_integration_with_subtype_and_listener: 1.27s → 0.66s - test_integration_with_listener_v6_records: 1.27s → 0.67s - test_integration_with_listener_ipv6 (same pattern, not in #1707 list): 0.67s - test_async_zeroconf_service_types: 1.54s → 0.77s
diff --git a/tests/services/test_types.py b/tests/services/test_types.py
@@ -47,10 +47,10 @@ def test_integration_with_listener(disable_duplicate_packet_suppression):
     )
     zeroconf_registrar.registry.async_add(info)
     try:
-        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.2)
         assert type_ in service_types
         _clear_cache(zeroconf_registrar)
-        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.2)
         assert type_ in service_types
 
     finally:
@@ -79,10 +79,10 @@ def test_integration_with_listener_v6_records(disable_duplicate_packet_suppressi
     )
     zeroconf_registrar.registry.async_add(info)
     try:
-        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.2)
         assert type_ in service_types
         _clear_cache(zeroconf_registrar)
-        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.2)
         assert type_ in service_types
 
     finally:
@@ -115,10 +115,10 @@ def test_integration_with_listener_ipv6(disable_duplicate_packet_suppression):
     )
     zeroconf_registrar.registry.async_add(info)
     try:
-        service_types = ZeroconfServiceTypes.find(ip_version=r.IPVersion.V6Only, timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(ip_version=r.IPVersion.V6Only, timeout=0.2)
         assert type_ in service_types
         _clear_cache(zeroconf_registrar)
-        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.2)
         assert type_ in service_types
 
     finally:
@@ -147,10 +147,10 @@ def test_integration_with_subtype_and_listener(disable_duplicate_packet_suppress
     )
     zeroconf_registrar.registry.async_add(info)
     try:
-        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(interfaces=["127.0.0.1"], timeout=0.2)
         assert discovery_type in service_types
         _clear_cache(zeroconf_registrar)
-        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.5)
+        service_types = ZeroconfServiceTypes.find(zc=zeroconf_registrar, timeout=0.2)
         assert discovery_type in service_types
 
     finally:
diff --git a/tests/test_asyncio.py b/tests/test_asyncio.py
@@ -919,14 +919,16 @@ async def test_async_zeroconf_service_types(quick_timing: None) -> None:
     )
     task = await zeroconf_registrar.async_register_service(info)
     await task
-    # Ensure we do not clear the cache until after the last broadcast is processed
-    await asyncio.sleep(0.2)
+    # Wait for the last announce broadcast before clearing. With
+    # `quick_timing` the broadcasts use _REGISTER_TIME=10ms apart so
+    # 50ms is plenty.
+    await asyncio.sleep(0.05)
     _clear_cache(zeroconf_registrar.zeroconf)
     try:
-        service_types = await AsyncZeroconfServiceTypes.async_find(interfaces=["127.0.0.1"], timeout=0.5)
+        service_types = await AsyncZeroconfServiceTypes.async_find(interfaces=["127.0.0.1"], timeout=0.2)
         assert type_ in service_types
         _clear_cache(zeroconf_registrar.zeroconf)
-        service_types = await AsyncZeroconfServiceTypes.async_find(aiozc=zeroconf_registrar, timeout=0.5)
+        service_types = await AsyncZeroconfServiceTypes.async_find(aiozc=zeroconf_registrar, timeout=0.2)
         assert type_ in service_types
 
     finally:
