chore: use a constant for address record types (#1149)

bdraco · web-flow · commit d3213d746a7d · 2023-04-02T10:01:02.000-10:00
diff --git a/src/zeroconf/_handlers.py b/src/zeroconf/_handlers.py
@@ -47,6 +47,7 @@
 from ._updates import RecordUpdate, RecordUpdateListener
 from ._utils.time import current_time_millis, millis_to_seconds
 from .const import (
+    _ADDRESS_RECORD_TYPES,
     _CLASS_IN,
     _CLASS_UNIQUE,
     _DNS_OTHER_TTL,
@@ -71,7 +72,6 @@
 _AnswerWithAdditionalsType = Dict[DNSRecord, Set[DNSRecord]]
 
 _MULTICAST_DELAY_RANDOM_INTERVAL = (20, 120)
-_ADDRESS_RECORD_TYPES = {_TYPE_A, _TYPE_AAAA}
 _RESPOND_IMMEDIATE_TYPES = {_TYPE_NSEC, _TYPE_SRV, *_ADDRESS_RECORD_TYPES}
 
 
diff --git a/src/zeroconf/_services/browser.py b/src/zeroconf/_services/browser.py
@@ -53,6 +53,7 @@
 from .._utils.name import cached_possible_types, service_type_name
 from .._utils.time import current_time_millis, millis_to_seconds
 from ..const import (
+    _ADDRESS_RECORD_TYPES,
     _BROWSER_BACKOFF_LIMIT,
     _BROWSER_TIME,
     _CLASS_IN,
@@ -63,8 +64,6 @@
     _MDNS_ADDR,
     _MDNS_ADDR6,
     _MDNS_PORT,
-    _TYPE_A,
-    _TYPE_AAAA,
     _TYPE_PTR,
 )
 
@@ -385,7 +384,7 @@ def _async_process_record_update(
         if old_record or record.is_expired(now):
             return
 
-        if record_type in (_TYPE_A, _TYPE_AAAA):
+        if record_type in _ADDRESS_RECORD_TYPES:
             # Iterate through the DNSCache and callback any services that use this address
             for type_, name in self._names_matching_types(
                 {service.name for service in self.zc.cache.async_entries_with_server(record.name)}
diff --git a/src/zeroconf/const.py b/src/zeroconf/const.py
@@ -139,6 +139,8 @@
     _TYPE_NSEC: "nsec",
 }
 
+_ADDRESS_RECORD_TYPES = {_TYPE_A, _TYPE_AAAA}
+
 _HAS_A_TO_Z = re.compile(r'[A-Za-z]')
 _HAS_ONLY_A_TO_Z_NUM_HYPHEN = re.compile(r'^[A-Za-z0-9\-]+$')
 _HAS_ONLY_A_TO_Z_NUM_HYPHEN_UNDERSCORE = re.compile(r'^[A-Za-z0-9\-\_]+$')

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,8 @@`
`139`	`139`	`_TYPE_NSEC: "nsec",`
`140`	`140`	`}`
`141`	`141`
	`142`	`+_ADDRESS_RECORD_TYPES = {_TYPE_A, _TYPE_AAAA}`
	`143`	`+`
`142`	`144`	`_HAS_A_TO_Z = re.compile(r'[A-Za-z]')`
`143`	`145`	`_HAS_ONLY_A_TO_Z_NUM_HYPHEN = re.compile(r'^[A-Za-z0-9\-]+$')`
`144`	`146`	`_HAS_ONLY_A_TO_Z_NUM_HYPHEN_UNDERSCORE = re.compile(r'^[A-Za-z0-9\-\_]+$')`