fix: prune dead transports from the engine on connection loss

bdraco · bdraco · commit b262b0eade32 · 2026-06-21T18:09:32.000-05:00
diff --git a/src/zeroconf/_engine.py b/src/zeroconf/_engine.py
@@ -126,6 +126,21 @@ async def _async_create_endpoints(self) -> None:
             if s in self._respond_sockets:
                 self._respond_sockets.remove(s)
 
+    def _async_remove_listener(self, listener: AsyncListener) -> None:
+        """Drop a listener and its wrapped transports from the engine lists.
+
+        Called from ``AsyncListener.connection_lost`` so a transport that
+        dies (interface down, IP changed) stops being used as a sender
+        instead of raising ``EHOSTUNREACH`` on every send forever.
+        """
+        wrapped = listener.transport
+        transport = wrapped.transport if wrapped is not None else None
+        if listener in self.protocols:
+            self.protocols.remove(listener)
+        if transport is not None:
+            self.readers = [w for w in self.readers if w.transport is not transport]
+            self.senders = [w for w in self.senders if w.transport is not transport]
+
     def _async_cache_cleanup(self) -> None:
         """Periodic cache cleanup."""
         now = current_time_millis()
diff --git a/src/zeroconf/_listener.py b/src/zeroconf/_listener.py
@@ -356,4 +356,5 @@ def connection_made(self, transport: asyncio.BaseTransport) -> None:
         self.sock_description = f"{wrapped_transport.fileno} ({wrapped_transport.sock_name})"
 
     def connection_lost(self, exc: Exception | None) -> None:
-        """Handle connection lost."""
+        """Prune this transport from the engine so a dead socket is not reused."""
+        self.zc.engine._async_remove_listener(self)
diff --git a/tests/test_engine.py b/tests/test_engine.py
@@ -84,6 +84,30 @@ async def test_setup_releases_socket_ownership(aiozc_loopback: AsyncZeroconf) ->
     assert engine.senders
 
 
+@pytest.mark.asyncio
+async def test_connection_lost_prunes_transport(aiozc_loopback: AsyncZeroconf) -> None:
+    """A lost transport is removed from the engine reader/sender/protocol lists."""
+    await aiozc_loopback.zeroconf.async_wait_for_start()
+    engine = aiozc_loopback.zeroconf.engine
+    assert engine.senders
+    reader_count = len(engine.readers)
+    sender_count = len(engine.senders)
+    protocol_count = len(engine.protocols)
+
+    dead_transport = engine.senders[0].transport
+    protocol = next(
+        p for p in engine.protocols if p.transport is not None and p.transport.transport is dead_transport
+    )
+    protocol.connection_lost(None)
+
+    assert len(engine.senders) == sender_count - 1
+    assert len(engine.readers) == reader_count - 1
+    assert len(engine.protocols) == protocol_count - 1
+    assert all(w.transport is not dead_transport for w in engine.senders)
+    assert all(w.transport is not dead_transport for w in engine.readers)
+    assert protocol not in engine.protocols
+
+
 @pytest.mark.asyncio
 async def test_async_close_propagates_outer_cancellation(aiozc_loopback: AsyncZeroconf) -> None:
     """Outer-task cancellation while awaiting setup propagates to the caller."""
