chore: drop stale comment from _async_evict_oldest fall-through

bdraco · bdraco · commit 39ab7550d565 · 2026-05-17T21:23:26.000-07:00
The comment said drift would surface via
``test_cache_total_records_invariant_under_mixed_ops``, but that
test only exercises well-formed paths and never produces a
heap-empty-with-counter-nonzero state. The test that actually pins
the broken-invariant recovery is
``test_cache_eviction_empty_heap_returns_without_evicting``. Per
``CLAUDE.md`` ("default to no comments"; cross-references rot when
referents are renamed) the comment shouldn't exist at all — the
function name and docstring already describe the contract, and the
while-loop fall-through is self-explanatory.
diff --git a/src/zeroconf/_cache.py b/src/zeroconf/_cache.py
@@ -135,9 +135,6 @@ def _async_evict_oldest(self) -> None:
                 continue
             self._async_remove(record)
             return
-        # Heap-empty fall-through is unreachable by the cache invariant
-        # (every counted record has a heap entry); accounting drift would
-        # surface in tests via test_cache_total_records_invariant_under_mixed_ops.
 
     def _maybe_rebuild_heap(self) -> None:
         """Rebuild ``_expire_heap`` when stale entries dominate live ones."""
