coverage

bdraco · bdraco · commit 0ab8f2843f0b · 2021-06-15T13:50:30.000-10:00
diff --git a/tests/utils/test_name.py b/tests/utils/test_name.py
@@ -10,8 +10,27 @@
 from zeroconf import BadTypeInNameException
 
 
-def test_service_type_name():
-    """Test overlong service_type_name."""
+def test_service_type_name_overlong_type():
+    """Test overlong service_type_name type."""
     with pytest.raises(BadTypeInNameException):
         nameutils.service_type_name("Tivo1._tivo-videostream._tcp.local.")
     nameutils.service_type_name("Tivo1._tivo-videostream._tcp.local.", strict=False)
+
+
+def test_service_type_name_overlong_full_name():
+    """Test overlong service_type_name full name."""
+    with pytest.raises(BadTypeInNameException):
+        nameutils.service_type_name(
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "._tivo-videostream._tcp.local."
+        )
+    with pytest.raises(BadTypeInNameException):
+        nameutils.service_type_name(
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1Tivo1"
+            "._tivo-videostream._tcp.local.",
+            strict=False,
+        )
diff --git a/zeroconf/_utils/name.py b/zeroconf/_utils/name.py
@@ -74,6 +74,9 @@ def service_type_name(type_: str, *, strict: bool = True) -> str:  # pylint: dis
     :param type_: Type, SubType or service name to validate
     :return: fully qualified service name (eg: _http._tcp.local.)
     """
+    if len(type_) > 256:
+        # https://datatracker.ietf.org/doc/html/rfc6763#section-7.2
+        raise BadTypeInNameException("Full name (%s) must be > 256 bytes" % type_)
 
     if type_.endswith((_TCP_PROTOCOL_LOCAL_TRAILER, _NONTCP_PROTOCOL_LOCAL_TRAILER)):
         remaining = type_[: -len(_TCP_PROTOCOL_LOCAL_TRAILER)].split('.')
