You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we saw in issue #224, the setup.py script can be tricky. Usually, a setup.py script should describe its metadata, but should avoid any "complicated" command logic.
We had this situation already in the past: in issue #148 we discouraged the use of python setup.py test in documentation.
Proposal
I propose to remove the Tox and Clean classes in the setup.py script for the following reasons:
Situation
As we saw in issue #224, the
setup.pyscript can be tricky. Usually, asetup.pyscript should describe its metadata, but should avoid any "complicated" command logic.We had this situation already in the past: in issue #148 we discouraged the use of
python setup.py testin documentation.Proposal
I propose to remove the
ToxandCleanclasses in thesetup.pyscript for the following reasons:setup.pyscript should be "as simple as possible".Maybe I miss a good reason, but at the moment, I think they are not really that essential, right?
Questions
@python-semver/reviewers What do you think about this proposal? 😉