Fix Privileged flag being inverted by interface generator

igo95862 · igo95862 · commit 01a0e44b2fdd · 2024-10-19T19:13:20.000+01:00
By default libsystemd makes all methods privileged unless the
`org.freedesktop.systemd1.Privileged` is set. The code generator
only set the unprivileged flag only if introspection flag was set
which is completely inverted logic.

This change means there will be a lot of `DbusUnprivilegedFlag` used
in the generated code but this is a correct way.
diff --git a/src/sdbus/interface_generator.py b/src/sdbus/interface_generator.py
@@ -273,15 +273,15 @@ def __init__(self, element: Element):
         self.python_name = camel_case_to_snake_case(self.method_name)
 
         self.is_deprecated = False
-        self.is_unpriveledged = False
+        self.is_priveledged = False
 
         self.iter_sub_elements(element)
 
     def _flags_iter(self) -> Iterator[str]:
         if self.is_deprecated:
             yield 'DbusDeprecatedFlag'
 
-        if self.is_unpriveledged:
+        if not self.is_priveledged:
             yield 'DbusUnprivilegedFlag'
 
     @property
@@ -298,7 +298,7 @@ def _parse_annotation_data(self,
         if annotation_name == 'org.freedesktop.DBus.Deprecated':
             self.is_deprecated = parse_str_bool(annotation_value)
         elif annotation_name == 'org.freedesktop.systemd1.Privileged':
-            self.is_unpriveledged = parse_str_bool(annotation_value)
+            self.is_priveledged = parse_str_bool(annotation_value)
         else:
             ...
 
