Unable to compile MacOS wheel for Python 3.4

Under MacOS/clang, the compilation of the module with Python 3.4 runtime fails, see https://travis-ci.org/python-rapidjson/python-rapidjson/jobs/273856525

Disable MacOS wheels

@hynek

As I do not have MacOS around to do further experiments, it's unlikely I will be able to solve this by myself. Maybe @hynek or @carlpulley can shed some light?

Relevant errors are:

              if (Py_IS_NAN(d)) {
                  ^
  /Library/Frameworks/Python.framework/Versions/3.4/include/python3.4m/pymath.h:93:22: note: expanded from macro 'Py_IS_NAN'
  #define Py_IS_NAN(X) isnan(X)
                       ^
  /usr/include/c++/4.2.1/cmath:551:5: note: 'std::isnan' declared here
      isnan(_Tp __f) { return ::__gnu_cxx::__capture_isnan(__f); }
      ^
  ./rapidjson.cpp:1654:24: error: use of undeclared identifier 'isinf'
              } else if (Py_IS_INFINITY(d)) {
                         ^
  /Library/Frameworks/Python.framework/Versions/3.4/include/python3.4m/pymath.h:113:31: note: expanded from macro 'Py_IS_INFINITY'
  #    define Py_IS_INFINITY(X) isinf(X)
                                ^

Could this be some C-header-used-in-C++ weirdness?

Relevant Python code for 3.4 is at:

https://github.com/python/cpython/blob/86a713cb0c110b6798ca7f9e630fc511ee0a4028/Include/pymath.h#L82-L118 and it at least seems to have detected the presence of the functions it's complaining about. So my mostly ignorant guess is that it's less about macOS per se and more about compiler versions/strictness?

I use OSX, I've only ever used python-rapidjson on 3.5 and 3.6 and it works perfectly. We don't test py34 with tox. We could add that in there and see if its specific to Py3.4 on OSX

Yes, the problem I got is only with py34.

I don't have an easy way to test either, but I think this idea might work except with math.h instead of cmath. 1ff9a18

I don't want to hijack the wrong thread, as I'm using Python 3.6, but I'm getting a similar error:

https://pastebin.com/6QNStUQ1

Any chance you could investigate a bit, maybe trying out suggestions above?

Sure thing. The suggestion you are referring to is replacing that include? Giving that a shot right now...

So steps performed:

Checked out repo
Updated submodules
Edited rapidjson.cpp and replaced with "math.h"
Ran python setup.py build

Same errors occur. https://pastebin.com/WRt17PaU

Going to dig a bit more on versions of GCC running here, but I'm just jumping into this, so I don't have an intuition of where to look. If someone can throw me some pointers, I can put some time into it.

Thank you for trying, I'm thinking about asking advice to the RapidJSON folks...

I actually just ran into this on my other Mac... Not sure why but I think it might be related to an older version of clang or something. On my mac that I have no issues with:

Apple LLVM version 8.0.0 (clang-800.0.42.1)

on my mac I have this issue:

Apple LLVM version 7.3.0 (clang-703.0.31)

that is the only difference I've seen so far.

I'm using py35, so might be different... The errors are similar:

/Library/Frameworks/Python.framework/Versions/3.5/include/python3.5m/pymath.h:93:22: note: expanded from macro 'Py_IS_NAN'
    #define Py_IS_NAN(X) isnan(X)
                         ^
    /usr/include/c++/4.2.1/cmath:551:5: note: 'std::isnan' declared here
        isnan(_Tp __f) { return ::__gnu_cxx::__capture_isnan(__f); }
        ^
    ./rapidjson.cpp:1652:24: error: use of undeclared identifier 'isinf'
                } else if (Py_IS_INFINITY(d)) {
                           ^
    /Library/Frameworks/Python.framework/Versions/3.5/include/python3.5m/pymath.h:113:31: note: expanded from macro 'Py_IS_INFINITY'
    #    define Py_IS_INFINITY(X) isinf(X)
                                  ^

I did:

export CC=gcc
export CXX=g++

and still get the errors:

 ./rapidjson.cpp:1137:60: warning: conversion from string literal to 'char *' is deprecated [-Wc++11-compat-deprecated-writable-strings]
         T_UINT, offsetof(DecoderObject, parseMode), READONLY, "parse_mode"},
                                                               ^
    ./rapidjson.cpp:1644:17: error: use of undeclared identifier 'isnan'; did you mean 'std::isnan'?
                if (Py_IS_NAN(d)) {
                    ^
    /Library/Frameworks/Python.framework/Versions/3.5/include/python3.5m/pymath.h:93:22: note: expanded from macro 'Py_IS_NAN'
    #define Py_IS_NAN(X) isnan(X)
                         ^
    /usr/include/c++/4.2.1/cmath:551:5: note: 'std::isnan' declared here
        isnan(_Tp __f) { return ::__gnu_cxx::__capture_isnan(__f); }
        ^
    ./rapidjson.cpp:1652:24: error: use of undeclared identifier 'isinf'
                } else if (Py_IS_INFINITY(d)) {
                           ^
    /Library/Frameworks/Python.framework/Versions/3.5/include/python3.5m/pymath.h:113:31: note: expanded from macro 'Py_IS_INFINITY'
    #    define Py_IS_INFINITY(X) isinf(X)

so its not clang.

That's so strange! But system/compiler versions may explain why the trouble does not always manifest itself: for example, the Travis build succeeds except with Python 3.4...

This is on El Capitan, I'm upgrading to Sierra now, so I'll let you know if that fixes the issue on this system.

Replace Py_IS_NAN() and Py_IS_INFINITY() with std::isnan() and std::i…

It seems that #88 fixes the problem, at least on Travis CI: any chance some of you could try it and confirm?

Just tested and it works.

This should be fixed in current master, I will probably release 0.3 next week or so. Thank you all.

Can I interest you into calling it 1.0? 😇

I just released v0.3, let's see whether the macOS wheel appears on PyPI.

Wrt v1.0, I'd like to have further attempts at issue #80 before that...

Well, it seems there's still something wrong with the MacOS recipe, it fails to find twine, even if it appears to be installed...

Alternative way to execute twine

Yay! It seems I ruled it, at last!

Navigation Menu

Repository navigation

Unable to compile MacOS wheel for Python 3.4 #78

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Unable to compile MacOS wheel for Python 3.4 #78

Description

Activity

lelit commented on Sep 11, 2017

hynek commented on Sep 24, 2017

sontek commented on Sep 29, 2017

lelit commented on Sep 29, 2017

kenrobbins commented on Sep 29, 2017

thanosd commented on Oct 27, 2017

lelit commented on Oct 27, 2017

thanosd commented on Oct 27, 2017

thanosd commented on Oct 27, 2017

lelit commented on Oct 27, 2017

sontek commented on Oct 31, 2017

sontek commented on Oct 31, 2017

sontek commented on Oct 31, 2017

lelit commented on Oct 31, 2017

sontek commented on Oct 31, 2017

lelit commented on Dec 14, 2017

sontek commented on Dec 15, 2017

lelit commented on Dec 15, 2017

hynek commented on Dec 15, 2017

lelit commented on Dec 20, 2017

lelit commented on Dec 20, 2017

lelit commented on Dec 21, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions