Repository navigation
Enable the possibility to not bundle rapidjson with the package? #60
Description
Both rapidjson and python-rapidjson have been bundled for conda-forge,
However, the latter makes use of the rapidjson submodule.
It would probably make sense for the setup.py to handle the case where an installation prefix for rapidjson is provided instead of a submodule.
For reference, such a setup.py has been done for pyzmq which can either bundle zeromq or not.
Activity
lelit commentedon Jan 23, 2017
Can you give some more information on this? Is it just some kind of option so that you can build python-rapidjson using a different path where the compiler search for the rapidjson includes, or what?
SylvainCorlay commentedon Jan 23, 2017
Yes exactly. For example, the pyzmq wheel from pypi bundles libzmq. The one from conda uses the libzmq from conda which is its own package.
Add a “--rj-include-dir=” option to the setup script
lelit commentedon Jan 26, 2017
Sylvain, does this fulfill your needs?
SylvainCorlay commentedon Jan 26, 2017
@lelit thanks! I will try this for the conda-forge recipe and get back to you.
lelit commentedon Feb 17, 2017
Just curious, did that help?
lelit commentedon Mar 2, 2017
The proposed change is included in version 0.0.9, please reopen the issue if that's not enough.
Thank you!
SylvainCorlay commentedon Mar 2, 2017
THanks @lelit and sorry for the late reply. I am updating the conda recipe to 0.10.0 and testing the functionality.
Check for --rj-include-dir earlier