Repository navigation
Tests fail with Python 3.8 #125
Description
Failure is persistent with Python 3.8 on linux/osx/win (64bit):
=================================== FAILURES ===================================
____________________________ test_intenums_as_ints _____________________________
@pytest.mark.unit
def test_intenums_as_ints():
class IE(enum.IntEnum):
val = 123
bigval = 123123123123123123123123
> assert rj.dumps([IE.val, IE.bigval]) == "[123,123123123123123123123123]"
E AssertionError: assert '[<IE.val: 12...23123123123>]' == '[123,12312312...123123123123]'
E - [<IE.val: 123>,<IE.bigval: 123123123123123123123123>]
E + [123,123123123123123123123123]
tests/test_enum.py:22: AssertionError
========= 1 failed, 679 passed, 16 skipped, 2 xfailed in 2.65 seconds ==========
Activity
Use repr() instead of str() to obtain string representation of PyLong…
lelit commentedon Nov 2, 2019
This seems to fix the issue, at least for 3.7 and 3.8... let's see.
dbast commentedon Nov 2, 2019
Will there be a bugfix release soon or should we cherrypick the mentioned patch?
lelit commentedon Nov 2, 2019
I could easily make a release if you are in a hurry: I was waiting for pypa/cibuildwheel#172...
dbast commentedon Nov 3, 2019
All fine. Cherry-picked aa16ff9 ... it now build+tests fine with Python 3.6, 3.7, 3.8 (on linux64, osx64, win64) :)
lelit commentedon Nov 13, 2019
I released version 0.9.0 that includes this fix.
Thanks for the report!