test: Expect failure for silent_mode GUC on PostgreSQL 9.2 and later

elprans · elprans · commit e9d82b761f0e · 2012-08-27T23:08:48.000-04:00
silent_mode has been removed in PostgreSQL 9.2, so expect a failure in
the corresponding test.  Additionally, avoid unnecessarily seting it to
avoid failures on 9.2 and later for the same reason.
diff --git a/postgresql/temporal.py b/postgresql/temporal.py
@@ -134,7 +134,6 @@ def init(self,
 			listen_addresses = 'localhost',
 			log_destination = 'stderr',
 			log_min_messages = 'FATAL',
-			silent_mode = 'off',
 			unix_socket_directory = cluster.data_directory,
 		))
 		cluster.settings.update(dict(
diff --git a/postgresql/test/test_cluster.py b/postgresql/test/test_cluster.py
@@ -33,7 +33,6 @@ def init(self, *args, **kw):
 			'max_connections' : '8',
 			'listen_addresses' : 'localhost',
 			'port' : '6543',
-			'silent_mode' : 'off',
 			'unix_socket_directory' : self.cluster.data_directory,
 		})
 
@@ -47,11 +46,15 @@ def testSilentMode(self):
 			# silent_mode is not supported on windows by PG.
 			if sys.platform in ('win32','win64'):
 				pass
+			elif self.cluster.installation.version_info[:2] >= (9, 2):
+				pass
 			else:
 				raise
 		else:
 			if sys.platform in ('win32','win64'):
-				self.fail("silent_mode supported on windows")
+				self.fail("silent_mode unexpectedly supported on windows")
+			elif self.cluster.installation.version_info[:2] >= (9, 2):
+				self.fail("silent_mode unexpectedly supported on PostgreSQL >=9.2")
 
 	def testSuperPassword(self):
 		self.init(
diff --git a/postgresql/test/test_connect.py b/postgresql/test/test_connect.py
@@ -86,7 +86,6 @@ def configure_cluster(self):
 			listen_addresses = listen_addresses,
 			log_destination = 'stderr',
 			log_min_messages = 'FATAL',
-			silent_mode = 'off',
 			unix_socket_directory = self.cluster.data_directory,
 		))
 		# 8.4 turns prepared transactions off by default.
