Expand running() to remove the process when it's no longer running.

James William Pye · James William Pye · commit a9bea2a2cac3 · 2009-04-21T02:56:17.000-07:00
If a cluster is started with silent_mode=on, postgres will fork off and die
leaving the dead subprocess. Postgres is running properly, but Cluster is
foolishly looking at .daemon_process, not the pidfile.
diff --git a/postgresql/cluster.py b/postgresql/cluster.py
@@ -382,7 +382,15 @@ def running(self):
 		"""
 		if self.daemon_process is not None:
 			r = self.daemon_process.poll()
-			return r is None
+			if r is not None:
+				pid = self.get_pid_from_file()
+				if pid is not None:
+					# daemon process does not exist, but there's a pidfile.
+					self.daemon_process = None
+					return self.running()
+				return False
+			else:
+				return True
 		else:
 			pid = self.get_pid_from_file()
 			if pid is None:
