Remove redundant code.

James William Pye · James William Pye · commit a11e58f3641b · 2009-04-03T04:44:22.000-07:00
The driver's message printer needs to handle write() failures otherwise it stop
a connection in its tracks if stderr is closed.
diff --git a/postgresql/api.py b/postgresql/api.py
@@ -16,6 +16,7 @@
 that makes up the basic interfaces used to work with a PostgreSQL.
 """
 import os
+import sys
 import warnings
 import collections
 from abc import ABCMeta, abstractproperty, abstractmethod
@@ -354,8 +355,8 @@ def __str__(self):
 
 		code = "" if not self.code or self.code == "00000" else '(' + self.code + ')'
 		return sev + code + ': ' + self.message + locstr + detailstr + \
-			os.linesep + '  ' + \
-			(os.linesep + '  ').join([': '.join(x[1:]) for x in ss]) + \
+			os.linesep + \
+			os.linesep.join([': '.join(x[1:]) for x in ss]) + \
 			os.linesep
 
 	@property
@@ -1432,10 +1433,12 @@ def print_message(self, msg, file = None):
 		if file and not file.closed:
 			try:
 				file.write(str(msg))
-			except Exception as err:
-				sys.excepthook(*sys.exc_info())
-		else:
-			warnings.warn("sys.stderr unavailable for printing messages")
+			except Exception:
+				try:
+					sys.excepthook(*sys.exc_info())
+				except Exception:
+					# What more can be done?
+					pass
 
 	def handle_warnings_and_messages(self, source, this, obj):
 		"""
diff --git a/postgresql/driver/pq3.py b/postgresql/driver/pq3.py
@@ -3193,19 +3193,6 @@ def connect(self, **kw) -> Connection:
 	def ife_snapshot_text(self):
 		return 'postgresql.driver.pq3'
 
-	def throw_warnings(self, src, first, obj):
-		"use ife_sever() to stop this"
-		if isinstance(obj, pg_exc.Warning):
-			warnings.warn(obj)
-
-	def print_messages(self, src, first, obj):
-		"use ife_sever() to stop this"
-		if not isinstance(obj, pg_exc.Warning) and isinstance(obj, pg_api.Message):
-			sys.stderr.write(str(obj))
-
 	def __init__(self, typio = TypeIO):
 		self.typio = typio
-		self.ife_connect(
-			self.throw_warnings,
-			self.print_messages
-		)
+		super().__init__()
