Rename __call__ to transmit.

James William Pye · James William Pye · commit 5e65e8ed35a1 · 2010-03-21T22:41:38.000-07:00
It lends to its purpose.
diff --git a/postgresql/copyman.py b/postgresql/copyman.py
@@ -52,7 +52,7 @@ def __init__(self, manager, reason = None, faults = None):
 		self.faults = faults or {}
 
 	def __str__(self):
-		return self.reason or 'copy '
+		return self.reason or 'copy aborted'
 
 # The identifier for PQv3 copy data.
 PROTOCOL_PQv3 = "PQv3"
@@ -277,9 +277,9 @@ class Receiver(Fitting):
 	_e_label = 'RECEIVER'
 
 	@abstractmethod
-	def __call__(self):
+	def transmit(self):
 		"""
-		Finish the reception of data.
+		Finish the reception of the accepted data.
 		"""
 
 	@abstractmethod
@@ -508,7 +508,7 @@ class NullReceiver(Receiver):
 	protocol = PROTOCOL_NULL
 	state = 'null'
 
-	def __call__(self):
+	def transmit(self):
 		# Nothing to do.
 		pass
 
@@ -530,7 +530,7 @@ def __init__(self, send):
 	def accept(self, data):
 		self.view = data
 
-	def __call__(self):
+	def transmit(self):
 		while self.view:
 			self.view = self.view[self.send(self.view):]
 
@@ -626,7 +626,7 @@ def __init__(self, callable):
 		self.lines = None
 		super().__init__()
 
-	def __call__(self):
+	def transmit(self):
 		if self.lines is not None:
 			self.callable(self.lines)
 		self.lines = None
@@ -734,7 +734,7 @@ def reconcile(self, r):
 		"""
 		if r.protocol not in self.protocols:
 			raise RuntimeError("cannot add new receivers to copy operations")
-		r()
+		r.transmit()
 		# Okay, add it back.
 		self.receivers.add(r)
 
@@ -761,7 +761,7 @@ def _service_receivers(self):
 		for x in self.receivers:
 			# Process all the receivers.
 			try:
-				x()
+				x.transmit()
 			except Exception as e:
 				faults[x] = e
 		if faults:
