style: add _Style.name setter

Steve Canny · Steve Canny · commit f945031c4de9 · 2015-02-08T00:01:14.000-08:00
diff --git a/docx/oxml/parts/styles.py b/docx/oxml/parts/styles.py
@@ -38,6 +38,13 @@ def name_val(self):
             return None
         return name.val
 
+    @name_val.setter
+    def name_val(self, value):
+        self._remove_name()
+        if value is not None:
+            name = self._add_name()
+            name.val = value
+
 
 class CT_Styles(BaseOxmlElement):
     """
diff --git a/docx/styles/style.py b/docx/styles/style.py
@@ -42,6 +42,10 @@ def name(self):
         """
         return self._element.name_val
 
+    @name.setter
+    def name(self, value):
+        self._element.name_val = value
+
     @property
     def style_id(self):
         """
diff --git a/features/sty-style-props.feature b/features/sty-style-props.feature
@@ -9,7 +9,6 @@ Feature: Get and set style properties
      Then style.name is the known name
 
 
-  @wip
   Scenario: Set name
     Given a style having a known name
      When I assign a new name to the style
diff --git a/tests/styles/test_style.py b/tests/styles/test_style.py
@@ -112,6 +112,11 @@ def it_knows_its_name(self, name_get_fixture):
         style, expected_value = name_get_fixture
         assert style.name == expected_value
 
+    def it_can_change_its_name(self, name_set_fixture):
+        style, new_value, expected_xml = name_set_fixture
+        style.name = new_value
+        assert style._element.xml == expected_xml
+
     # fixture --------------------------------------------------------
 
     @pytest.fixture(params=[
@@ -144,6 +149,17 @@ def name_get_fixture(self, request):
         style = BaseStyle(element(style_cxml))
         return style, expected_value
 
+    @pytest.fixture(params=[
+        ('w:style',                   'Foo', 'w:style/w:name{w:val=Foo}'),
+        ('w:style/w:name{w:val=Foo}', 'Bar', 'w:style/w:name{w:val=Bar}'),
+        ('w:style/w:name{w:val=Bar}', None,  'w:style'),
+    ])
+    def name_set_fixture(self, request):
+        style_cxml, new_value, expected_style_cxml = request.param
+        style = BaseStyle(element(style_cxml))
+        expected_xml = xml(expected_style_cxml)
+        return style, new_value, expected_xml
+
     @pytest.fixture(params=[
         ('w:style',                   WD_STYLE_TYPE.PARAGRAPH),
         ('w:style{w:type=paragraph}', WD_STYLE_TYPE.PARAGRAPH),
