tab: add TabStops.__delitem__()

DKWoods · Steve Canny · commit df0406325033 · 2016-05-27T12:49:56.000-07:00
diff --git a/docx/text/tabstops.py b/docx/text/tabstops.py
@@ -26,6 +26,19 @@ def __init__(self, element):
         super(TabStops, self).__init__(element, None)
         self._pPr = element
 
+    def __delitem__(self, idx):
+        """
+        Remove the tab at offset *idx* in this sequence.
+        """
+        tabs = self._pPr.tabs
+        try:
+            tabs.remove(tabs[idx])
+        except (AttributeError, IndexError):
+            raise IndexError('tab index out of range')
+
+        if len(tabs) == 0:
+            self._pPr.remove(tabs)
+
     def __getitem__(self, idx):
         """
         Enables list-style access by index.
diff --git a/features/tab-access-tabs.feature b/features/tab-access-tabs.feature
@@ -32,7 +32,6 @@ Feature: Access TabStop objects
       |   3   |     4     |
 
 
-  @wip
   Scenario: TabStops.__delitem__()
     Given a tab_stops having 3 tab stops
      When I remove a tab stop
diff --git a/tests/text/test_tabstops.py b/tests/text/test_tabstops.py
@@ -164,8 +164,42 @@ def it_can_add_a_tab_stop(self, add_tab_fixture):
         tab_stops.add_tab_stop(position, **kwargs)
         assert tab_stops._element.xml == expected_xml
 
+    def it_can_delete_a_tab_stop(self, del_fixture):
+        tab_stops, idx, expected_xml = del_fixture
+        del tab_stops[idx]
+        assert tab_stops._element.xml == expected_xml
+
+    def it_raises_on_del_idx_invalid(self, del_raises_fixture):
+        tab_stops, idx = del_raises_fixture
+        with pytest.raises(IndexError) as exc:
+            del tab_stops[idx]
+        assert exc.value.args[0] == 'tab index out of range'
+
     # fixture --------------------------------------------------------
 
+    @pytest.fixture(params=[
+        ('w:pPr/w:tabs/w:tab{w:pos=42}',                   0,
+         'w:pPr'),
+        ('w:pPr/w:tabs/(w:tab{w:pos=24},w:tab{w:pos=42})', 0,
+         'w:pPr/w:tabs/w:tab{w:pos=42}'),
+        ('w:pPr/w:tabs/(w:tab{w:pos=24},w:tab{w:pos=42})', 1,
+         'w:pPr/w:tabs/w:tab{w:pos=24}'),
+    ])
+    def del_fixture(self, request):
+        pPr_cxml, idx, expected_cxml = request.param
+        tab_stops = TabStops(element(pPr_cxml))
+        expected_xml = xml(expected_cxml)
+        return tab_stops, idx, expected_xml
+
+    @pytest.fixture(params=[
+        ('w:pPr',                        0),
+        ('w:pPr/w:tabs/w:tab{w:pos=42}', 1),
+    ])
+    def del_raises_fixture(self, request):
+        tab_stops_cxml, idx = request.param
+        tab_stops = TabStops(element(tab_stops_cxml))
+        return tab_stops, idx
+
     @pytest.fixture(params=[
         ('w:pPr', Twips(42), {},
          'w:pPr/w:tabs/w:tab{w:pos=42,w:val=left}'),
