doc: add Document.end_bookmark()

scanny · scanny · commit 7bc7728cf9bf · 2021-05-15T15:32:43.000-07:00
diff --git a/docx/blkcntnr.py b/docx/blkcntnr.py
@@ -52,6 +52,10 @@ def add_table(self, rows, cols, width):
         self._element._insert_tbl(tbl)
         return Table(tbl, self)
 
+    def end_bookmark(self, bookmark):
+        """Return `bookmark` after closing it after last block item in container."""
+        raise NotImplementedError
+
     @property
     def paragraphs(self):
         """
diff --git a/docx/document.py b/docx/document.py
@@ -114,7 +114,7 @@ def core_properties(self):
 
     def end_bookmark(self, bookmark):
         """Return `bookmark` after closing it at end of this document."""
-        raise NotImplementedError
+        return self._body.end_bookmark(bookmark)
 
     @property
     def inline_shapes(self):
diff --git a/tests/test_document.py b/tests/test_document.py
@@ -90,11 +90,6 @@ def it_can_add_a_table(self, add_table_fixture):
         assert table == table_
         assert table.style == style
 
-    def it_can_save_the_document_to_a_file(self, save_fixture):
-        document, file_ = save_fixture
-        document.save(file_)
-        document._part.save.assert_called_once_with(file_)
-
     def it_provides_access_to_its_bookmarks(self, document_part_, bookmarks_):
         document_part_.bookmarks = bookmarks_
         document = Document(None, document_part_)
@@ -108,6 +103,16 @@ def it_provides_access_to_its_core_properties(self, core_props_fixture):
         core_properties = document.core_properties
         assert core_properties is core_properties_
 
+    def it_can_end_a_bookmark(self, _body_prop_, body_, bookmark_):
+        _body_prop_.return_value = body_
+        body_.end_bookmark.return_value = bookmark_
+        document = Document(None, None)
+
+        bookmark = document.end_bookmark(bookmark_)
+
+        body_.end_bookmark.assert_called_once_with(bookmark_)
+        assert bookmark is bookmark_
+
     def it_provides_access_to_its_inline_shapes(self, inline_shapes_fixture):
         document, inline_shapes_ = inline_shapes_fixture
         assert document.inline_shapes is inline_shapes_
@@ -117,6 +122,11 @@ def it_provides_access_to_its_paragraphs(self, paragraphs_fixture):
         paragraphs = document.paragraphs
         assert paragraphs is paragraphs_
 
+    def it_can_save_the_document_to_a_file(self, save_fixture):
+        document, file_ = save_fixture
+        document.save(file_)
+        document._part.save.assert_called_once_with(file_)
+
     def it_provides_access_to_its_sections(self, document_part_, Sections_, sections_):
         document_elm = element("w:document")
         Sections_.return_value = sections_
