bmk: add _PartBookmarkFinder._names_so_far

Benjamin Toornstra · scanny · commit 4838fb0c3c7f · 2019-07-13T16:34:35.000-07:00
diff --git a/docx/bookmark.py b/docx/bookmark.py
@@ -124,4 +124,4 @@ def _name_already_used(self, name):
     @lazyproperty
     def _names_so_far(self):
         """set composed to track bookmark names encountered in document traversal."""
-        raise NotImplementedError
+        return set()
diff --git a/tests/test_bookmark.py b/tests/test_bookmark.py
@@ -218,6 +218,11 @@ def it_knows_whether_a_bookmark_name_was_already_used(
         assert names_so_far_.add.call_args_list == calls
         assert already_used is expected_value
 
+    def it_composes_a_set_in_which_to_track_used_bookmark_names(self):
+        finder = _PartBookmarkFinder(None)
+        names_so_far = finder._names_so_far
+        assert names_so_far == set()
+
     # fixtures -------------------------------------------------------
 
     @pytest.fixture(
