fixed auto insert for rope complete

zcodes · zcodes · commit bfd70f735b26 · 2019-03-08T09:41:52.000+08:00
For details, see `:h completeopt` in vim.

vim has many flags of option &amp;completeopt, the flags like menu, menuone,
noinsert, noselect and so on control the autocomplete behaviour.

e.g. if the set completeopt=menu, and there's only one possible
completions, the vim will not popup a menu and just insert the
completions, this like auto insert __init__ describe above, user there's
no chance to confirm the completions they want or not.

but if set completeopt=menuone,noinsert, vim will popup menu also when
there is only one match. for case above, vim will popup a menu with one
completion item __init__ and let user choose insert it or escape, if add
noselect with &amp;completeopt, vim will even not selected the first
completion item.
diff --git a/autoload/pymode/rope.vim b/autoload/pymode/rope.vim
@@ -15,14 +15,18 @@ endfunction
 
 fun! pymode#rope#complete(dot)
     if pumvisible()
-        return "\<C-n>"
+        if stridx('noselect', &completeopt) != -1
+            return "\<C-n>"
+        else
+            return ""
+        endif
     endif
     if a:dot
         PymodePython rope.complete(True)
     else
         PymodePython rope.complete()
     endif
-    return pumvisible() ? "\<C-p>\<Down>" : ""
+    return pumvisible() && stridx('noselect', &completeopt) != -1 ? "\<C-p>\<Down>" : ""
 endfunction
 
 fun! pymode#rope#complete_on_dot() "{{{
diff --git a/pymode/rope.py b/pymode/rope.py
@@ -94,7 +94,8 @@ def complete(dot=False):
     line = env.lines[row - 1]
     cline = line[:col] + p_prefix + line[col:]
     if cline != line:
-        env.curbuf[row - 1] = env.prepare_value(cline, dumps=False)
+        if 'noinsert' not in env.var('&completeopt'):
+            env.curbuf[row - 1] = env.prepare_value(cline, dumps=False)
     env.current.window.cursor = (row, col + len(p_prefix))
     env.run('complete', col - len(prefix) + len(p_prefix) + 1, proposals)
     return True
