Merge pull request #1141 from lieryan/fix-move-refactoring

diraol · web-flow · commit 71a7f0805212 · 2023-06-24T02:18:22.000-03:00
Fix Global and Module MoveRefactoring
diff --git a/doc/pymode.txt b/doc/pymode.txt
@@ -618,14 +618,31 @@ code to call it instead.
     let g:pymode_rope_use_function_bind = '<C-c>ru'
 
 
-Move method/fields ~
+Move refactoring ~
                                                                *pymode-rope-move*
 
+Moving method/fields
+
 It happens when you perform move refactoring on a method of a class. In this
 refactoring, a method of a class is moved to the class of one of its
 attributes. The old method will call the new method. If you want to change all
 of the occurrences of the old method to use the new method you can inline it
 afterwards.
+
+Moving global variable/class/function into another module
+
+It happens when you perform move refactoring on global variable/class/function.
+In this refactoring, the object being refactored will be moved to a destination
+module. All references to the object being moved will be updated to point to
+the new location.
+
+Moving module variable/class/function into a package
+
+It happens when you perform move refactoring on a name referencing a module.
+In this refactoring, the module being refactored will be moved to a destination
+package. All references to the object being moved will be updated to point to
+the new location.
+
 >
     let g:pymode_rope_move_bind = '<C-c>rv'
 
diff --git a/pymode/rope.py b/pymode/rope.py
@@ -701,6 +701,15 @@ def get_refactor(ctx):
             offset = None
         return move.create_move(ctx.project, ctx.resource, offset)
 
+    @staticmethod
+    def get_changes(refactor, input_str, in_hierarchy=False):
+        with RopeContext() as ctx:
+            if isinstance(refactor, (move.MoveGlobal, move.MoveModule)):
+                dest = ctx.project.pycore.find_module(input_str)
+            else:
+                dest = input_str
+            return super(MoveRefactoring, MoveRefactoring).get_changes(refactor, dest, in_hierarchy=in_hierarchy)
+
 
 class ChangeSignatureRefactoring(Refactoring):
 
