Skip to content

Commit 0c095e7

Browse files
committed
Remove references to PYTHON_VERSION_SHORT
1 parent 83bfab1 commit 0c095e7

File tree

6 files changed

+2
-10
lines changed

6 files changed

+2
-10
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ jobs:
4444
4545
# Export for docker compose
4646
export PYTHON_VERSION="${PYTHON_VERSION}"
47-
export PYTHON_VERSION_SHORT="${{ matrix.python-version }}"
4847
4948
# Build the docker compose services
5049
docker compose build python-mode-tests
@@ -54,9 +53,8 @@ jobs:
5453
# Get the appropriate Python version
5554
PYTHON_VERSION=$(bash scripts/check_python_docker_image.sh "${{ matrix.python-version }}")
5655
57-
# Set Python version environment variables
56+
# Set environment variables
5857
export PYTHON_VERSION="${PYTHON_VERSION}"
59-
export PYTHON_VERSION_SHORT="${{ matrix.python-version }}"
6058
export TEST_SUITE="${{ matrix.test-suite }}"
6159
export GITHUB_ACTIONS=true
6260

.github/workflows/test_pymode.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,10 @@ jobs:
4646
run: |
4747
docker compose build -q \
4848
--build-arg PYTHON_VERSION="${{ matrix.python_version.full }}" \
49-
--build-arg PYTHON_VERSION_SHORT="${{ matrix.python_version.short }}" \
5049
python-mode-tests
5150
5251
- name: Run tests with Python ${{ matrix.python_version.short }}
5352
run: |
5453
docker compose run --rm \
5554
-e PYTHON_VERSION="${{ matrix.python_version.full }}" \
56-
-e PYTHON_VERSION_SHORT="${{ matrix.python_version.short }}" \
5755
python-mode-tests

Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
ARG PYTHON_VERSION_SHORT
21
ARG PYTHON_VERSION
32
# Use official Python slim image instead of non-existent base
43
# Note: For Python 3.13, use 3.13.0 if just "3.13" doesn't work

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ services:
44
context: .
55
dockerfile: Dockerfile
66
args:
7-
- PYTHON_VERSION_SHORT=${PYTHON_VERSION_SHORT:-3.11}
87
- PYTHON_VERSION=${PYTHON_VERSION:-3.11}
98
volumes:
109
# Mount the current directory to allow for development and testing
@@ -25,7 +24,6 @@ services:
2524
context: .
2625
dockerfile: Dockerfile
2726
args:
28-
- PYTHON_VERSION_SHORT=${PYTHON_VERSION_SHORT:-3.11}
2927
- PYTHON_VERSION=${PYTHON_VERSION:-3.11}
3028
volumes:
3129
- .:/workspace/python-mode

scripts/run-tests-docker.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ echo -e "${YELLOW}Building python-mode test environment...${NC}"
6363

6464
DOCKER_BUILD_ARGS=(
6565
--build-arg PYTHON_VERSION="${PYTHON_VERSION}"
66-
--build-arg PYTHON_VERSION_SHORT="${PYTHON_VERSION_SHORT}"
6766
)
6867

6968
# Build the Docker image

scripts/test-all-python-versions.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ for short_version in "${!PYTHON_VERSIONS[@]}"; do
3636
echo -e "${BLUE}Testing with Python $short_version ($full_version)${NC}"
3737
echo -e "${BLUE}========================================${NC}"
3838

39-
if docker compose run --rm -e PYTHON_VERSION="$full_version" -e PYTHON_VERSION_SHORT="$short_version" python-mode-tests; then
39+
if docker compose run --rm -e PYTHON_VERSION="$full_version" python-mode-tests; then
4040
echo -e "${GREEN}✓ Tests passed with Python $short_version${NC}"
4141
else
4242
echo -e "${RED}✗ Tests failed with Python $short_version${NC}"

0 commit comments

Comments
 (0)