From 0d465378694222f6b839ee7d3024121c24bd1af3 Mon Sep 17 00:00:00 2001 From: Jordon Maule Date: Wed, 30 Aug 2023 21:34:31 +0000 Subject: [PATCH 1/2] fix: no significant weather, nsw, code transtalion --- metar/Metar.py | 1 + 1 file changed, 1 insertion(+) diff --git a/metar/Metar.py b/metar/Metar.py index 01c436fe..3859417b 100644 --- a/metar/Metar.py +++ b/metar/Metar.py @@ -286,6 +286,7 @@ def xlate_loc(loc): "FC": "funnel cloud", "SS": "sandstorm", "DS": "dust storm", + "NSW": "no significant weather", } WEATHER_SPECIAL = {"+FC": "tornado"} From 0b814bf9e004de2c0b78d2a5f732771be96fedc9 Mon Sep 17 00:00:00 2001 From: Jordon Maule Date: Thu, 31 Aug 2023 00:23:10 +0000 Subject: [PATCH 2/2] test: add tests for weather_other codes --- test/test_metar.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/test/test_metar.py b/test/test_metar.py index 53c1148e..c68dc104 100644 --- a/test/test_metar.py +++ b/test/test_metar.py @@ -699,3 +699,34 @@ def test_windshear_runway_identifier(): assert len(m.windshear) == 1 assert m.windshear[0] == "22L" + +def test_present_weather_others(): + # PO, sand whirls + code = "VEIM 301200Z 16007KT 7000 PO SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'sand whirls' + + # SQ, squalls + code = "VEIM 301200Z 16007KT 7000 SQ SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'squalls' + + # FC, funnel cloud + code = "VEIM 301200Z 16007KT 7000 FC SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'funnel cloud' + + # SS, sandstorm + code = "VEIM 301200Z 16007KT 7000 SS SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'sandstorm' + + # DS, dust storm + code = "VEIM 301200Z 16007KT 7000 DS SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'dust storm' + + # NSW, No significant weather + code = "VEIM 301200Z 16007KT 7000 NSW SCT018 31/27 Q1007 NOSIG" + m = Metar.Metar(code, month=8, year=2023) + assert m.present_weather() == 'no significant weather'