Skip to content

Commit c5c5130

Browse files
ngoldbaumjonathanunderwood
authored andcommitted
add missing thread-unsafe reasons
1 parent 30a7a7e commit c5c5130

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

tests/block/test_block_0.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,10 @@ def test_1(data, mode, store_size, c_return_bytearray, d_return_bytearray, dicti
8888

8989

9090
# Test multi threaded usage with all valid variations of input
91-
@pytest.mark.thread_unsafe
91+
@pytest.mark.thread_unsafe(
92+
reason=("Test is already explicitly multithreaded, should "
93+
"not be run in a thread pool.")
94+
)
9295
def test_2(data, mode, store_size, dictionary):
9396
(c_kwargs, d_kwargs) = setup_kwargs(mode, store_size)
9497

tests/frame/test_frame_5.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
(b'a' * 1024 * 1024),
99
]
1010

11+
1112
@pytest.fixture(
1213
params=test_data,
1314
ids=[

tests/stream/test_stream_0.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,10 @@ def setup_kwargs(strategy, mode, buffer_size, store_comp_size,
9696

9797

9898
# Test single threaded usage with all valid variations of input
99-
@pytest.mark.thread_unsafe
99+
@pytest.mark.thread_unsafe(
100+
reason=("test modifies fixtures that would be shared, see "
101+
"https://github.com/Quansight-Labs/pytest-run-parallel/issues/14")
102+
)
100103
def test_1(data, strategy, mode, buffer_size, store_comp_size,
101104
c_return_bytearray, d_return_bytearray, dictionary):
102105
if buffer_size >= (1 << (8 * store_comp_size['store_comp_size'])):

0 commit comments

Comments
 (0)