Add tests that reprioritize() rejects bad weights

alexwlchan · alexwlchan · commit b4189b2fd4a5 · 2017-01-22T12:52:55.000Z
diff --git a/test/test_priority.py b/test/test_priority.py
@@ -398,24 +398,29 @@ def test_can_insert_stream_with_exclusive_dependency_on_0(self,
         'priority',
         object
     ])
-    def test_insert_stream_with_non_integer_weight_is_error(self, weight):
+    def test_stream_with_non_integer_weight_is_error(self, weight):
         """
-        Creating a stream with a non-integer weight is rejected.
+        Giving a stream a non-integer weight is rejected.
         """
         p = priority.PriorityTree()
         with pytest.raises(priority.BadWeightError) as err:
             p.insert_stream(stream_id=1, weight=weight)
         assert err.value.args[0] == 'Stream weight should be an integer'
 
+        p.insert_stream(stream_id=2)
+        with pytest.raises(priority.BadWeightError) as err:
+            p.reprioritize(stream_id=2, weight=weight)
+        assert err.value.args[0] == 'Stream weight should be an integer'
+
     @pytest.mark.parametrize('weight', [
         0,
         257,
         1000,
         -42,
     ])
-    def test_insert_stream_with_out_of_bounds_weight_is_error(self, weight):
+    def test_stream_with_out_of_bounds_weight_is_error(self, weight):
         """
-        Creating a stream with an out-of-bounds integer weight is rejected.
+        Giving a stream an out-of-bounds integer weight is rejected.
         """
         p = priority.PriorityTree()
         with pytest.raises(priority.BadWeightError) as err:
@@ -424,6 +429,13 @@ def test_insert_stream_with_out_of_bounds_weight_is_error(self, weight):
             err.value.args[0] ==
             'Stream weight must be between 1 and 256 (inclusive)')
 
+        p.insert_stream(stream_id=2)
+        with pytest.raises(priority.BadWeightError) as err:
+            p.reprioritize(stream_id=2, weight=weight)
+        assert (
+            err.value.args[0] ==
+            'Stream weight must be between 1 and 256 (inclusive)')
+
 
 class TestPriorityTreeOutput(object):
     """
