Merge pull request #45 from python-hyper/altsvc-memoryview

Lukasa · Lukasa · commit b3434d1c3ed6 · 2016-04-13T11:42:19.000+01:00
Ensure AltSvc's repr works properly.
diff --git a/hyperframe/frame.py b/hyperframe/frame.py
@@ -710,12 +710,12 @@ def serialize_body(self):
     def parse_body(self, data):
         try:
             origin_len = struct.unpack("!H", data[0:2])[0]
-            self.origin = data[2:2+origin_len]
+            self.origin = data[2:2+origin_len].tobytes()
 
             if len(self.origin) != origin_len:
                 raise InvalidFrameError("Invalid ALTSVC frame body.")
 
-            self.field = data[2+origin_len:]
+            self.field = data[2+origin_len:].tobytes()
         except (struct.error, ValueError):
             raise InvalidFrameError("Invalid ALTSVC frame body.")
 
diff --git a/test/test_frames.py b/test/test_frames.py
@@ -690,6 +690,13 @@ def test_altsvc_frame_without_origin_parses_properly(self):
         assert f.body_len == 19
         assert f.stream_id == 1
 
+    def test_altsvc_frame_without_origin_parses_with_good_repr(self):
+        f = decode_frame(self.payload_without_origin)
+
+        assert repr(f) == (
+            "AltSvcFrame(Stream: 1; Flags: None): 000068323d223a383030..."
+        )
+
     def test_altsvc_frame_with_origin_and_stream_serializes_properly(self):
         # This frame is not valid, but we allow it to be serialized anyway.
         f = AltSvcFrame(stream_id=1)
