Skip to content

When will be the time to drop Python 2 compatibility? #274

Closed

Description

I recently attempted to use one of my favorite static analysis tools with hpack and it choked on

try:  # pragma: no cover
    basestring = basestring
except NameError:  # pragma: no cover
    basestring = (str, bytes)

in hpack.py because it doesn't support analyzing Python 2 source. My impression at this time is that this isn't a problem with the tool; that more than four years after the Python 2 turndown it's appropriate for tools to drop support for analyzing Python 2 source.


So... while I see that https://hyper.readthedocs.io/en/latest advertises that the hyper family of projects supports 2.7.9-and-later in the Python 2 line, do y'all hyper maintainers have a notion of when you're going to be dropping Python 2 compatibility from the source?

Activity

  1. Kriechi commented on Aug 14, 2024

    @Kriechi
    Member

    Sounds good to me! Happy to review a PR, though not sure when we will ship the next major release to include the change.

  2. nathanielmanistaatgoogle commented on Nov 23, 2024

    @nathanielmanistaatgoogle
    Author

    Apologies that I didn't get to this on my own, and thanks much for the change! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions