Add mattermost service support - #342
Merged
Merged
Conversation
gpocentek
reviewed
Oct 31, 2017
gpocentek
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this patch! Please have a look at my comment inline.
|
|
||
| # Optional fields | ||
| 'username', 'password', 'jira_issue_transition_id')), | ||
| 'mattermost': (('webhook',), ('username', 'channel')), |
Contributor
There was a problem hiding this comment.
I can't find references to username and channel in the gitlab documentation and code. Is this really supported?
Contributor
Author
There was a problem hiding this comment.
Looking at services API, it looks like username and channel are optional fields.
Contributor
There was a problem hiding this comment.
You're right. I guess I missed it.
Contributor
Author
|
It seems like this is not working, but the problem is in GitLab. At the moment, even if we send username / channel parameters to GitLab, they are not set. Strange, since it's documented in docs. I opened an issue on gitlab. |
Contributor
Author
|
Issue is fixed in GitLab. |
Contributor
|
Thanks for the feedback @matejzero |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for mattermost service.
I hope this is all I need to do:)