From 062f8f6a917abc037714129691a845c16b070ff6 Mon Sep 17 00:00:00 2001 From: "John L. Villalovos" Date: Sun, 18 Apr 2021 10:47:06 -0700 Subject: [PATCH] fix: argument type was not a tuple as expected While adding type-hints mypy flagged this as an issue. The third argument to register_custom_action is supposed to be a tuple. It was being passed as a string rather than a tuple of strings. --- gitlab/v4/objects/merge_requests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitlab/v4/objects/merge_requests.py b/gitlab/v4/objects/merge_requests.py index 938cb5a09..83e8f44d8 100644 --- a/gitlab/v4/objects/merge_requests.py +++ b/gitlab/v4/objects/merge_requests.py @@ -234,7 +234,7 @@ def pipelines(self, **kwargs): path = "%s/%s/pipelines" % (self.manager.path, self.get_id()) return self.manager.gitlab.http_get(path, **kwargs) - @cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha")) + @cli.register_custom_action("ProjectMergeRequest", tuple(), ("sha",)) @exc.on_http_error(exc.GitlabMRApprovalError) def approve(self, sha=None, **kwargs): """Approve the merge request.