Skip to content

ProjectMergeRequest.commits() has surprising returns #266

Closed

Description

@AstraLuma

I'm not sure why exactly, but it seems that .commits() (v4) has three kinds of returns:

  • An actual list of ProjectCommit objects
  • An empty list (even though the merge request has commits attached to it)
  • Raising a 404 error

I'm finding this very puzzling, especially since the endpoint is not documented to return a 404.

(This is all on the same project, btw.)

Activity

  1. AstraLuma commented on May 26, 2017

    @AstraLuma
    ContributorAuthor

    Ahhh.

    The Commits URL is constructed using the id, not the iid.

  2. locked as resolved and limited conversation to collaborators on Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions