ProjectMember.save() does not work because 'ProjectMemberAllManager' object has no attribute 'update'

Description of the problem, including code/CLI snippet

ProjectMember.save() does not work because 'ProjectMemberAllManager' object has no attribute 'update'.

project = GitlabClient().projects.get('my_proj_name')
member = project.members.list()[0]
member.access_level = 30
member.save()

Expected Behavior

Member saves with new properties.
Actual Behavior

Traceback (most recent call last):
  File "gitlab_client.py", line 85, in update_project_permissions
    member.save()
  File "/Users/theoturner/Library/Python/3.8/lib/python/site-packages/gitlab/mixins.py", line 551, in save
    server_data = self.manager.update(obj_id, updated_data, **kwargs)
AttributeError: 'ProjectMemberAllManager' object has no attribute 'update'

N.B. type(member) is <class 'gitlab.v4.objects.members.ProjectMember'> so I haven't accidentally got a ProjectMemberAllManager.
Specifications

python-gitlab version: 3.0.0, can be replicated in 2.8 and above
API version you are using (v3/v4): v4

Note: John Villalovos accidentally edited this and now attempting to return to original state...

This is a bit of a conceptional issue. Basically python-gitlab tries to be a small as possible layer on top of the GitLab API as possible. So there is less automatic logic that you might expect, as this reduces complexity of the library a lot

To update a member, you would need to get the exact member and update this object. You cannot update a list, as python-gitlab in it's principle cannot know what you're trying to update.

Basically you need to do:

project = GitlabClient().projects.get('my_proj_name')
member = project.members.list()[0]
member = project.members.get(member.id) # add this line
member.access_level = 30
member.save()

Does that clarify the usage?

@max-wittig

@max-wittig @nejch

~~This does make me wonder, why can't ProjectMemberAllManager' use a CRUDMixin`?~~

Figured it out. Because the path is .../members/all/

~~Well we should have a get method based on:~~

~~https://docs.gitlab.com/ee/api/members.html#get-a-member-of-a-group-or-project-including-inherited-and-invited-members~~ Never mind it does.

As I note if do just a project.members.get(ID) it won't work if the ID is not a direct member of the group.

In trying as a CRUDMixin save() and others won't work due to the path having /members/all/

And after saying all that. That is why it has a RetrieveMixin.

So my theory is that the code should be:

project = GitlabClient().projects.get('my_proj_name')
member = project.members_all.list()[0]
member = project.members_all.get(member.id) # add this line
member.access_level = 30
member.save()

Notice everything is members_all

But not sure that will work. Because still ProjectMemberAllManager 😟

Really should make sure to use project.members.list() for best results.

@theoturner

project = GitlabClient().projects.get('my_proj_name')
member = project.members.list()[0]
member.access_level = 30
member.save()

@theoturner I'm assuming that the actual call was member = project.members_all.list() as otherwise I'm not sure how would get a ProjectMemberAllManager

fix: members: use new *All objects for *AllManager managers

fix(members): use new *All objects for *AllManager managers

Navigation Menu

Repository navigation

ProjectMember.save() does not work because 'ProjectMemberAllManager' object has no attribute 'update' #1825

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ProjectMember.save() does not work because 'ProjectMemberAllManager' object has no attribute 'update' #1825

Description

Activity

max-wittig commented on Jan 11, 2022

JohnVillalovos commented on Jan 11, 2022

JohnVillalovos commented on Jan 11, 2022

JohnVillalovos commented on Jan 11, 2022

JohnVillalovos commented on Jan 11, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions