support async #41

sugizo · 2024-03-22T14:09:25Z

sugizo
Mar 22, 2024

nice to support async ?

the ffmpeg parameter can be run using another python ffmpeg module
e.g. module

typed-ffmpeg 
ffmpeg-python

e.g. code

import ffmpeg
url = 'http://takemotopiano.aa1.netvolante.jp:8190/nphMotionJpeg?Resolution=320x240&Quality=Standard&Framerate=30'
output = 'rtsp_%Y_%m_%d_%H_%M_%S.mp4'
scale = 'scale = 320 : -1'
segment_time = '00:01:00' 

stream = ffmpeg.input(url).output(filename = output, 
                                  vcodec = 'libx264', #acodec = 'copy', 
                                  reset_timestamps = 1, 
                                  strftime = 1, 
                                  f = 'segment', 
                                  segment_time = segment_time, 
                                  segment_atclocktime = 1, 
                                  vf = scale, 
                                  r = 25, ).overwrite_output().run_async()

to stop async
stream.terminate()

best regards

tikuma-lsuhsc · 2024-03-22T14:27:56Z

tikuma-lsuhsc
Mar 22, 2024
Maintainer

"Async" as in running both ffmpeg and python code in parallel is already supported via the stream I/O feature of the ffmpegio via ffmpegio.open. To effectively do the same as your code snippet with ffmpegio:

import ffmpegio as ff

output = 'rtsp_%Y_%m_%d_%H_%M_%S.mp4'
scale = 'scale = 320 : -1'
segment_time = '00:01:00' 

with ff.open(output, 'wv', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite=True) as stream:

    for F in my_frame_generator():
        stream.write(F)

If you don't want to use the context manager, you can call close() explicitly.

stream = ff.open(output, 'wv', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite=True) as stream:

try:
    for F in my_frame_generator():
        stream.write(F)
finally:
    stream.close()

As for the ffmpeg-python package, if you look in ffmpeg-python._run.py you can find that it just returns the subprocess.Popen object.

Now, if you meant "async" as in the ffmpegio API to have coroutines to work with Python's asyncio, I have no plan on supporting it atm.

0 replies

sugizo · 2024-03-22T15:00:39Z

sugizo
Mar 22, 2024
Author

conclusion
tested all your examples code above return error
quick analysis, problem is not mention the source rtsp url

code 1

output = 'rtsp_%Y_%m_%d_%H_%M_%S.mp4'
scale = 'scale = 320 : -1'
segment_time = '00:01:00' 

with ff.open(output, 'wb', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite = True) as stream:

    for F in my_frame_generator():
        stream.write(F)

result 1

Exception                                 Traceback (most recent call last)
[<ipython-input-6-5e079537aea1>](https://localhost:8080/#) in <cell line: 5>()
      3 segment_time = '00:01:00'
      4 
----> 5 with ff.open(output, 'wb', rate_in=25, 
      6              vcodec = 'libx264',
      7              reset_timestamps = 1,

1 frames
[/usr/local/lib/python3.10/dist-packages/ffmpegio/__init__.py](https://localhost:8080/#) in open(url_fg, mode, rate_in, shape_in, dtype_in, rate, shape, **kwds)
    230     unk = set(mode) - set("avrwf")
    231     if unk:
--> 232         raise Exception(
    233             f"Invalid FFmpeg streaming mode: {mode}. Unknown mode {unk} specified."
    234         )

Exception: Invalid FFmpeg streaming mode: wb. Unknown mode {'b'} specified.

code 2

output = 'rtsp_%Y_%m_%d_%H_%M_%S.mp4'
scale = 'scale = 320 : -1'
segment_time = '00:01:00' 

with ff.open(output, 'w', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite = True) as stream:

    for F in my_frame_generator():
        stream.write(F)

result 2

ValueError                                Traceback (most recent call last)
[<ipython-input-7-423483323fdd>](https://localhost:8080/#) in <cell line: 5>()
      3 segment_time = '00:01:00'
      4 
----> 5 with ff.open(output, 'w', rate_in=25, 
      6              vcodec = 'libx264',
      7              reset_timestamps = 1,

1 frames
[/usr/local/lib/python3.10/dist-packages/ffmpegio/__init__.py](https://localhost:8080/#) in open(url_fg, mode, rate_in, shape_in, dtype_in, rate, shape, **kwds)
    284             else:
    285                 # TODO identify based on file extension
--> 286                 raise ValueError(f"cannot auto-detect media type")
    287             video = not audio
    288     elif read:

ValueError: cannot auto-detect media type

code 3

output = 'rtsp_%Y_%m_%d_%H_%M_%S.mp4'
scale = 'scale = 320 : -1'
segment_time = '00:01:00' 

with ff.open(output, 'wv', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite = True) as stream:

    for F in my_frame_generator():
        stream.write(F)

result 3

NameError                                 Traceback (most recent call last)
[<ipython-input-9-015bed7d6bde>](https://localhost:8080/#) in <cell line: 5>()
     13              overwrite = True) as stream:
     14 
---> 15     for F in my_frame_generator():
     16         stream.write(F)

NameError: name 'my_frame_generator' is not defined

code 4

stream = with ff.open(output, 'wb', rate_in=25, 
             vcodec = 'libx264', 
             reset_timestamps = 1, 
             strftime = 1, 
             f = 'segment', 
             segment_time = segment_time, 
             segment_atclocktime = 1, 
             vf = scale, 
             overwrite=True) as stream:

try:
    for F in my_frame_generator():
        stream.write(F)
finally:
    stream.close()

result 4

File ["<ipython-input-8-925bc07892b0>"](https://localhost:8080/#), line 1
    stream = with ff.open(output, 'wb', rate_in=25,
             ^
SyntaxError: invalid syntax

best regards

0 replies

tikuma-lsuhsc · 2024-03-22T15:04:27Z

tikuma-lsuhsc
Mar 22, 2024
Maintainer

My bad, a finger slip. The open mode should be wv (as in write video) instead of wb and for the second example, drop with. (the post above has been fixed)

You need to write you own my_frame_generator() function to generate a frame (or frames) to write.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support async #41

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 3 comments

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Select a reply

Uh oh!

support async #41

Uh oh!

Uh oh!

sugizo Mar 22, 2024

Replies: 3 comments

Uh oh!

Uh oh!

tikuma-lsuhsc Mar 22, 2024 Maintainer

Uh oh!

sugizo Mar 22, 2024 Author

Uh oh!

Uh oh!

tikuma-lsuhsc Mar 22, 2024 Maintainer

sugizo
Mar 22, 2024

tikuma-lsuhsc
Mar 22, 2024
Maintainer

sugizo
Mar 22, 2024
Author

tikuma-lsuhsc
Mar 22, 2024
Maintainer