fixed overlay in basic filter

tikuma-lsuhsc · tikuma-lsuhsc · commit 99aec0bc7611 · 2022-06-18T14:27:42.000-05:00
diff --git a/src/ffmpegio/utils/filter.py b/src/ffmpegio/utils/filter.py
@@ -1472,7 +1472,7 @@ def video_basic_filter(
     bg_color = fill_color or "white"
 
     if remove_alpha:
-        vfilters.append(f"color=c={bg_color}[l1];[l1][in]scale2ref[l2],[l2]overlay")
+        vfilters.append(f"color=c={bg_color}[l1];[l1][in]scale2ref[l2],[l2]overlay=shortest=1")
 
     if square_pixels == "upscale":
         vfilters.append("scale='max(iw,ih*dar):max(iw/dar,ih):eval=init',setsar=1/1")
diff --git a/tests/test_video.py b/tests/test_video.py
@@ -105,6 +105,18 @@ def test_two_pass_write():
             show_log=True
         )
 
+def test_write_basic_filter():
+
+    url = "tests/assets/ffmpeg-logo.png"
+
+    _, B = video.read(url)
+    print(B)
+    B['buffer'] = B['buffer']*30
+    B['shape'] = (30, *B['shape'][1:])
+
+    with tempfile.TemporaryDirectory() as tmpdirname:
+        out_url = path.join(tmpdirname, "output.mp4")
+        video.write(out_url, 30, B, pix_fmt="yuv420p", show_log=True)
 
 if __name__ == "__main__":
     # test_create()
@@ -119,4 +131,15 @@ def test_two_pass_write():
 
     logging.basicConfig(level=logging.DEBUG)
 
-    test_two_pass_write()
+
+    #     B = video.read(url, show_log=True, s=(100, -2))
+    #     print(B["shape"])
+
+    #     url = "tests/assets/ffmpeg-logo.png"
+    #     B = video.read(
+    #         url,
+    #         show_log=True,
+    #         fill_color="red",
+    #     )
+
+    #     B = video.read(url, show_log=True, fill_color="red", pix_fmt="rgb24")
