SimpleReaderBase.close: poll before calling terminate

tikuma-lsuhsc · tikuma-lsuhsc · commit 2e1a2ffd76c8 · 2024-03-13T22:06:08.000-05:00
diff --git a/src/ffmpegio/streams/SimpleStreams.py b/src/ffmpegio/streams/SimpleStreams.py
@@ -105,13 +105,14 @@ def close(self):
         self._proc.stdout.close()
         self._proc.stderr.close()
 
-        try:
-            self._proc.terminate()
-            if self._proc.poll() is None:
-                self._proc.kill()
-        except:
-            print("failed to terminate")
-            pass
+        if self._proc.poll() is None:
+            try:
+                self._proc.terminate()
+                if self._proc.poll() is None:
+                    self._proc.kill()
+            except:
+                print("failed to terminate")
+                pass
 
         logger.debug(f"[reader main] FFmpeg closed? {self._proc.poll()}")
 
