don't silence TypeErrors in resolve_stubs.

radix · radix · commit a9db4d5bdcd1 · 2014-10-15T23:05:46.000-05:00
diff --git a/effect/test_testing.py b/effect/test_testing.py
@@ -158,6 +158,17 @@ def test_non_test_intent(self):
         self.assertIs(result_eff.intent, bare_effect.intent)
         self.assertEqual(result_eff.callbacks, [])
 
+    def test_type_error(self):
+        """
+        TypeErrors in callbacks (or otherwise performed intents) are propagated
+        resolve_stubs.
+
+        (This only exists because the initial implementation was done stupidly,
+        and had to be fixed.)
+        """
+        eff = Constant("foo").on(success=lambda r: None["foo"])
+        self.assertRaises(TypeError, resolve_stubs, eff)
+
 
 def _raise(e):
     raise e
diff --git a/effect/testing.py b/effect/testing.py
@@ -100,8 +100,9 @@ def resolve_stubs(effect):
         raise TypeError("effect must be Effect: %r" % (effect,))
 
     while type(effect) is Effect:
-        try:
+        if type(effect.intent) is StubIntent:
             effect = resolve_stub(effect)
-        except TypeError:
+        else:
             break
+
     return effect
