Apply suggestions from code review

corona10 · hugovk · web-flow · commit 55a4b5933e13 · 2022-12-03T22:59:55.000+09:00
Co-authored-by: Hugo van Kemenade &lt;hugovk@users.noreply.github.com&gt;
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -2,7 +2,7 @@ name: Upload Python Package
 
 on:
   release:
-    types: [created]
+    types: [published]
 
 jobs:
   deploy:
@@ -14,15 +14,17 @@ jobs:
       uses: actions/setup-python@v4
       with:
         python-version: '3.x'
+        cache: pip
+        cache-dependency-path: setup.py
     - name: Install dependencies
       run: |
-        python -m pip install --user --upgrade setuptools wheel
+        python -m pip install --upgrade build
     - name: Build
       run: |
-        python setup.py sdist bdist_wheel
+        python -m build
     - name: Publish distribution 📦 to PyPI
       if: startsWith(github.event.ref, 'refs/tags') || github.event_name == 'release'
-      uses: pypa/gh-action-pypi-publish@master
+      uses: pypa/gh-action-pypi-publish@release/v1
       with:
         user: __token__
         password: ${{ secrets.PYPI_API_TOKEN }}
diff --git a/setup.py b/setup.py
@@ -24,7 +24,7 @@
 #
 # Release a new version:
 #
-#  - go to the GitHub release tab: https://github.com/psf/pyperf/releases
+#  - go to the GitHub release tab: https://github.com/python/pyperformance/releases
 #  - click "Draft a new release" and fill the contents
 #  - finally click the "Publish release" button! Done!
 #  - monitor the publish status: https://github.com/python/pyperformance/actions/workflows/publish.yml

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`#`
`25`	`25`	`# Release a new version:`
`26`	`26`	`#`
`27`		`-# - go to the GitHub release tab: https://github.com/psf/pyperf/releases`
	`27`	`+# - go to the GitHub release tab: https://github.com/python/pyperformance/releases`
`28`	`28`	`# - click "Draft a new release" and fill the contents`
`29`	`29`	`# - finally click the "Publish release" button! Done!`
`30`	`30`	`# - monitor the publish status: https://github.com/python/pyperformance/actions/workflows/publish.yml`