From e853e41caa0870dd77e059dda731cb8f14290d44 Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Thu, 24 Jun 2021 09:57:30 -0700 Subject: [PATCH 1/2] Clarify late-registration edge-case --- pep-0634.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pep-0634.rst b/pep-0634.rst index 4240e0a487d..4b94edd31e9 100644 --- a/pep-0634.rst +++ b/pep-0634.rst @@ -365,7 +365,8 @@ where being a sequence is defined as its class being one of the following: - a class that inherits from ``collections.abc.Sequence`` - a Python class that has been registered as a ``collections.abc.Sequence`` - a builtin class that has its ``Py_TPFLAGS_SEQUENCE`` bit set -- a class that inherits from any of the above. +- a class that inherits from any of the above (including classes defined *before* a + parent's ``Sequence`` registration) The following standard library classes will have their ``Py_TPFLAGS_SEQUENCE`` bit set: @@ -440,7 +441,8 @@ where being a mapping is defined as its class being one of the following: - a class that inherits from ``collections.abc.Mapping`` - a Python class that has been registered as a ``collections.abc.Mapping`` - a builtin class that has its ``Py_TPFLAGS_MAPPING`` bit set -- a class that inherits from any of the above. +- a class that inherits from any of the above (including classes defined *before* a + parent's ``Mapping`` registration) The standard library classes ``dict`` and ``mappingproxy`` will have their ``Py_TPFLAGS_MAPPING`` bit set. From 609e1c582ba588456eff0a4b263501aceeeeeefa Mon Sep 17 00:00:00 2001 From: Brandt Bucher Date: Thu, 24 Jun 2021 09:57:53 -0700 Subject: [PATCH 2/2] Add myself as a CODEOWNER for PEPs 635 and 636 --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index deab4cd721b..0f573c31864 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -489,8 +489,8 @@ pep-0631.rst @pganssle pep-0632.rst @zooba pep-0633.rst @brettcannon pep-0634.rst @brandtbucher @gvanrossum -pep-0635.rst @gvanrossum -pep-0636.rst @gvanrossum +pep-0635.rst @brandtbucher @gvanrossum +pep-0636.rst @brandtbucher @gvanrossum pep-0637.rst @stevendaprano pep-0638.rst @markshannon pep-0639.rst @pfmoore