Support building mypycified mypy with PEP517 interface (#13445)

emmatyping · web-flow · commit d619c783d471 · 2022-09-16T23:37:08.000-07:00
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -115,7 +115,7 @@ jobs:
       if: ${{ matrix.test_mypyc }}
       run: |
         pip install -r test-requirements.txt
-        CC=clang MYPYC_OPT_LEVEL=0 python3 setup.py --use-mypyc build_ext --inplace
+        CC=clang MYPYC_OPT_LEVEL=0 MYPY_USE_MYPYC=1 pip install -e .
     - name: Setup tox environment
       run: tox -e ${{ matrix.toxenv }} --notest
     - name: Test
diff --git a/build-requirements.txt b/build-requirements.txt
@@ -1,3 +1,4 @@
+# NOTE: this needs to be kept in sync with the "requires" list in pyproject.toml
 -r mypy-requirements.txt
 types-psutil
 types-setuptools
diff --git a/mypy-requirements.txt b/mypy-requirements.txt
@@ -1,3 +1,4 @@
+# NOTE: this needs to be kept in sync with the "requires" list in pyproject.toml
 typing_extensions>=3.10
 mypy_extensions>=0.4.3
 typed_ast>=1.4.0,<2; python_version<'3.8'
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,7 +1,19 @@
 [build-system]
 requires = [
+    # NOTE: this needs to be kept in sync with mypy-requirements.txt
+    # and build-requirements.txt, because those are both needed for
+    # self-typechecking :/
     "setuptools >= 40.6.2",
     "wheel >= 0.30.0",
+    # the following is from mypy-requirements.txt
+    "typing_extensions>=3.10",
+    "mypy_extensions>=0.4.3",
+    "typed_ast>=1.4.0,<2; python_version<'3.8'",
+    "tomli>=1.1.0; python_version<'3.11'",
+    # the following is from build-requirements.txt
+    "types-psutil",
+    "types-setuptools",
+    "types-typed-ast>=1.5.8,<1.6.0",
 ]
 build-backend = "setuptools.build_meta"
 
diff --git a/setup.py b/setup.py
@@ -79,8 +79,8 @@ def run(self):
 
 USE_MYPYC = False
 # To compile with mypyc, a mypyc checkout must be present on the PYTHONPATH
-if len(sys.argv) > 1 and sys.argv[1] == "--use-mypyc":
-    sys.argv.pop(1)
+if len(sys.argv) > 1 and "--use-mypyc" in sys.argv:
+    sys.argv.remove("--use-mypyc")
     USE_MYPYC = True
 if os.getenv("MYPY_USE_MYPYC", None) == "1":
     USE_MYPYC = True

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+# NOTE: this needs to be kept in sync with the "requires" list in pyproject.toml`
`1`	`2`	`-r mypy-requirements.txt`
`2`	`3`	`types-psutil`
`3`	`4`	`types-setuptools`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+# NOTE: this needs to be kept in sync with the "requires" list in pyproject.toml`
`1`	`2`	`typing_extensions>=3.10`
`2`	`3`	`mypy_extensions>=0.4.3`
`3`	`4`	`typed_ast>=1.4.0,<2; python_version<'3.8'`