Distribution.files: Only return files that actually exist

jherland · jherland · commit 22d9ea5e3074 · 2023-03-11T12:49:10.000+01:00
Add an extra filter on the paths returned from Distribution.files, to prevent paths that don't exist on the filesystem from being returned. This attempts to solve the issue of .files returning incorrect information based on the inaccuracies of SOURCES.txt. As the code currently is organized, it is more complicated to write this such that it only applies to the information read from SOURCES.txt specifically, hence we apply it to _all_ of .files instead. This fixes #115, also in the case where there is no installed-files.txt file available. [1]: https://pip.pypa.io/en/stable/news/#v0-3 [2]: https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html#sources-txt-source-files-manifest
diff --git a/importlib_metadata/__init__.py b/importlib_metadata/__init__.py
@@ -474,7 +474,12 @@ def make_file(name, hash=None, size_str=None):
 
         @pass_none
         def make_files(lines):
-            return list(starmap(make_file, csv.reader(lines)))
+            return list(
+                filter(
+                    lambda package_path: package_path.locate().exists(),
+                    list(starmap(make_file, csv.reader(lines))),
+                )
+            )
 
         return make_files(
             self._read_files_distinfo()
