From 1cda41a0f87725615c90dcafdc7bfb61f9c886cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartosz=20S=C5=82awecki?= Date: Mon, 20 Apr 2026 06:31:01 +0200 Subject: [PATCH 1/2] Mention typo fixes and large PRs (#1782) * gh-1448: Add section on typo fixes and large PRs Add guidance on keeping typo-fix PRs small and focused, listing appropriate directories (Doc/, Misc/, Misc/NEWS.d/) and noting that large sweeping PRs may be closed. * gh-1448: Revise typo fixes section for clarity - Clarify which directories are appropriate for typo fixes - Encourage small, focused PRs to reduce reviewer notification burden - Explicitly note that large PRs or PRs outside listed directories may be closed with a reference to this section * gh-1448: Add PR size guidance to 'Making good PRs' section * gh-1448: Note that typo fixes do not require a linked issue * Apply suggestions from review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Carol Willing * Reference the `typo fixes` section * Mention `InternalDocs/` --------- Co-authored-by: Carol Willing --- getting-started/pull-request-lifecycle.rst | 29 +++++++++++++++++++--- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/getting-started/pull-request-lifecycle.rst b/getting-started/pull-request-lifecycle.rst index 7eb37ef90..78c8cfff0 100644 --- a/getting-started/pull-request-lifecycle.rst +++ b/getting-started/pull-request-lifecycle.rst @@ -27,7 +27,9 @@ Quick guide Here is a quick overview of how you can contribute to CPython: -#. `Create an issue`_ that describes your change [*]_ +#. `Create an issue`_ that describes your change. If it is trivial + (like :ref:`typo fixes `), or an issue already exists, + you can skip this step. #. :ref:`Create a new branch in Git ` from the ``main`` branch @@ -51,9 +53,6 @@ Here is a quick overview of how you can contribute to CPython: #. Celebrate contributing to CPython! :) -.. [*] If an issue is trivial (for example, typo fixes), or if an issue already exists, - you can skip this step. - Don't force-push ---------------- @@ -238,6 +237,11 @@ should do to help ensure that your pull request is accepted. changes, because there might be interferences unknown to you between your changes and some other part of the interpreter. +#. **Keep your pull request focused and small.** A pull request should address + one issue or add one feature. Combining multiple unrelated changes makes a + pull request harder to review and increases the number of people notified + unnecessarily. + #. Proper :ref:`documentation ` additions/changes should be included. .. _news-entry: @@ -359,6 +363,23 @@ See also `python/cpython#126133 `__. +.. _typo-fixes: + +Typo fixes +========== + +Fixing typos and grammatical errors in documentation is a +contribution that does not require a linked issue. The most appropriate +place for such fixes are the :cpy-file:`Doc/` (end-user documentation) +and :cpy-file:`InternalDocs/` directories. + + +Keep typo-fix PRs **small and focused**. Large PRs that touch many unrelated files +notify a large number of reviewers unnecessarily and are harder to review. +Large typo-fix PRs, or PRs touching directories outside those listed above, +may be closed with a reference to this section. + + .. _patchcheck: ``patchcheck`` From 6c418284cf253a2a586ae2aa7f2f12d108df1d87 Mon Sep 17 00:00:00 2001 From: Tam Nguyen Duc <1218621+tamnd@users.noreply.github.com> Date: Tue, 21 Apr 2026 00:21:27 +0700 Subject: [PATCH 2/2] Add Vietnamese translation details (#1789) Co-authored-by: Stan Ulbrych --- documentation/translations/translating.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/documentation/translations/translating.rst b/documentation/translations/translating.rst index e8e3dc32f..eb3eb164a 100644 --- a/documentation/translations/translating.rst +++ b/documentation/translations/translating.rst @@ -118,6 +118,10 @@ For more details about translations and their progress, see - Dmytro Kazanzhy (:github-user:`kazanzhy`, `email `__) - :github:`GitHub `, `Transifex `_ + * - Vietnamese (vi) + - Duc-Tam Nguyen (:github-user:`tamnd`) + - :github:`GitHub `, + `Transifex `_ How to get help