bpo-32529: imporved shutil.copyfileobj#5158
Conversation
tiran
left a comment
There was a problem hiding this comment.
Before this patch gets merged, please provide memory and performance benchmarks for this change on the ticket
In case your benchmark show an improvement, you have to provide tests for the change, too.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
After a good debate on #python i have removed the encoding checks as copyfileobj could potentially be used as encoding converter tool
|
here is the links to benchmark: the problem is the result times are so sparitic that not sure what to post as the result! I have tried with actual file as well and the results are all over the place. If any of you out there are can do benchmark that can produce accurate results and post the result it would help. |
Improved "copyfileobj" function to use less memory if provided Bytes IO and fixed potential encoding mismatch corruption in Text IO
https://bugs.python.org/issue32529