bpo-28206: Document signals Handlers, Sigmasks and Signals enums#28628
Merged
Conversation
Member
|
Hi @Bibo-Joshi, thanks for working on it. Could you please rebase your commit on top of main? You may have worked on an old clone, and based your commit on a commit from 2018. |
Updates the example and adds documentation for the enums signal.{Signals, Handlers, Sigmasks}
ad305b3 to
3dab7e0
Compare
Contributor
Author
|
Hi @JulienPalard. I based my branch on the branch of #1939, that's why these old commits where there. I've rebased onto main and force-pushed - the diff should be the same. |
Member
|
Thanks for rebasing! There's no need to squash in the cpython repository as when we merge a PR, we always |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://bugs.python.org/issue28206
This PR is a replacement/extension of #1939 which was closed incompleted. I tried to address the reviewers comments.
This change is relevant for versions 3.5+, though IISC only 3.9 still accepts bugfixes.
edit: The description of the enums is based on the docs of
ssl.VerifyModehttps://bugs.python.org/issue28206