Skip to content

[doc] Improve the punctuation in the documentation of the module atexit#25629

Merged
iritkatriel merged 1 commit into
python:mainfrom
geryogam:patch-20
Jun 22, 2021
Merged

[doc] Improve the punctuation in the documentation of the module atexit#25629
iritkatriel merged 1 commit into
python:mainfrom
geryogam:patch-20

Conversation

@geryogam

@geryogam geryogam commented Apr 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR will:

  • add a comma to a hardly parsable sentence;
  • uniformise quotation marks.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 26, 2021
@geryogam geryogam changed the title Improve the punctuation in the documentation of the atexit module Improve the punctuation in the documentation of the module atexit Apr 26, 2021
iritkatriel
iritkatriel reviewed May 22, 2021
View reviewed changes
Comment thread Doc/library/atexit.rst
@github-actions

github-actions Bot commented Jun 22, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 22, 2021
@iritkatriel iritkatriel changed the title Improve the punctuation in the documentation of the module atexit [doc] Improve the punctuation in the documentation of the module atexit Jun 22, 2021
@geryogam

geryogam commented Jun 22, 2021

Copy link
Copy Markdown
Contributor Author

Thank you for reviewing this @iritkatriel.

@iritkatriel

iritkatriel commented Jun 22, 2021

Copy link
Copy Markdown
Member

closing and reopening to kick the buildbot.

@iritkatriel iritkatriel reopened this Jun 22, 2021
@iritkatriel iritkatriel merged commit a6b47de into python:main Jun 22, 2021
@miss-islington

miss-islington commented Jun 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 22, 2021

Copy link
Copy Markdown

GH-26857 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

bedevere-bot commented Jun 22, 2021

Copy link
Copy Markdown

GH-26856 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 22, 2021
iritkatriel pushed a commit that referenced this pull request Jun 22, 2021
@miss-islington @geryogam
[doc] Improve punctuation atexit doc (GH-25629) (GH-26856)
e6ea428 
(cherry picked from commit a6b47de)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
iritkatriel pushed a commit that referenced this pull request Jun 22, 2021
@miss-islington @geryogam
[doc] Improve punctuation atexit doc (GH-25629) (GH-26857)
ef89b2b 
(cherry picked from commit a6b47de)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam geryogam deleted the patch-20 branch June 23, 2021 10:08
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geryogam @iritkatriel @miss-islington @bedevere-bot @the-knights-who-say-ni