Skip to content

bpo-42299: Remove formatter module#23476

Merged
corona10 merged 5 commits into
python:masterfrom
corona10:bpo-42299
Nov 25, 2020
Merged

bpo-42299: Remove formatter module#23476
corona10 merged 5 commits into
python:masterfrom
corona10:bpo-42299

Conversation

@corona10

@corona10 corona10 commented Nov 23, 2020

Copy link
Copy Markdown
Member

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2020-11-23-23-42-08.bpo-42299.Fdn4Wf.rst Outdated
@corona10 corona10 requested a review from vstinner November 24, 2020 14:21

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner Can you please take a look?

Comment thread Doc/whatsnew/3.10.rst
Comment thread Doc/whatsnew/3.10.rst Outdated

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm fine with removing the module. I just left minor remarks on the documentation, you're free to ignore them.

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I simply don't know if anything else is needed.

Comment thread Doc/whatsnew/3.10.rst

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested change, which applies to news also.

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @terryjreedy for the way better documentation than what I wrote :-) It's good to write down the full rationale, otherwise people get angry when they see that we remove modules on purpose.

@corona10

Copy link
Copy Markdown
Member Author

@vstinner @terryjreedy
Thanks Victor,
I will merge this PR after CI is passed ;)

@corona10 corona10 merged commit be319c0 into python:master Nov 25, 2020
@corona10 corona10 deleted the bpo-42299 branch November 25, 2020 13:17
@terryjreedy

Copy link
Copy Markdown
Member

Victor, I was inspired to add a 'solution' by your sentence from issue 39352: "I'm no longer sure that it's a good idea to remove a module from the stdlib without providing a solution for the few people relying on it." In this case, I am convinced that copying is a better solution than putting the module on PyPI.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants