Skip to content

bpo-30731: python.manifest fix#2328

Merged
zooba merged 2 commits into
python:masterfrom
segevfiner:bpo-30731-manifest
Jul 13, 2017
Merged

bpo-30731: python.manifest fix#2328
zooba merged 2 commits into
python:masterfrom
segevfiner:bpo-30731-manifest

Conversation

@segevfiner

@segevfiner segevfiner commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

I'm not seeing the typo mentioned in the issue (PC/python.manifest:3) but the xmlns is missing so I added it. Also trimmed some trailing whitespace because really...

For reference, here is a manifest generated by default on stuff built with VS2015:

<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
  <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    <security>
      <requestedPrivileges>
        <requestedExecutionLevel level='asInvoker' uiAccess='false' />
      </requestedPrivileges>
    </security>
  </trustInfo>
</assembly>

Documentation on this seems surprisingly poor on MSDN. Or maybe I just failed to find it...

@mention-bot

mention-bot commented Jun 22, 2017

Copy link
Copy Markdown

@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba to be a potential reviewer.

@zooba

zooba commented Jul 13, 2017

Copy link
Copy Markdown
Member

I want to merge this, but now it has a bug it needs a NEWS.d entry. Can you add one?

@zooba zooba merged commit c40ad03 into python:master Jul 13, 2017
@zooba

zooba commented Jul 13, 2017

Copy link
Copy Markdown
Member

Thanks!

zooba pushed a commit to zooba/cpython that referenced this pull request Jul 13, 2017
@segevfiner @zooba
bpo-30731: python.manifest fix (python#2328)
c097261 
bpo-30731: python.manifest fix
zooba added a commit that referenced this pull request Jul 13, 2017
@zooba
bpo-30731: python.manifest fix (#2328) (#2699)
d8e522f 
bpo-30731: python.manifest fix
@segevfiner segevfiner deleted the bpo-30731-manifest branch July 14, 2017 09:39
@AraHaan

AraHaan commented Nov 30, 2024

Copy link
Copy Markdown
Contributor

Sorry to necro this PR but I feel like having comments for the versions of windows on each entry on the compatibility section is needed and so I will do a followup PR to add it soon.

@AraHaan AraHaan mentioned this pull request Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@segevfiner @mention-bot @zooba @AraHaan @Mariatta @the-knights-who-say-ni